dlls/icmp/icmp_main.c -- attempt at fixing regression in r1.30 (RESEND)

Steven Edwards winehacker at gmail.com
Wed Dec 5 00:21:13 CST 2007


Hello,

On Dec 4, 2007 7:34 PM, Gerald Pfeifer <gerald at pfeifer.com> wrote:
> Since Alexandre has asked me to take care of overflow in some other
> context, I figured I could ping this underflow patch in return. ;-)
>
> Gerald
>
> ---------- Forwarded message ----------
> From: Gerald Pfeifer <gerald at pfeifer.com>
> To:  <wine-patches at winehq.org>, Damjan Jovanovic <damjan.jov at gmail.com>
> Date: Thu, 22 Nov 2007 22:32:08 +0100 (CET)
> Subject: dlls/icmp/icmp_main.c -- attempt at fixing regression in r1.30
>
> I believe revision 1.30 of dlls/icmp/icmp_main.c
>
>   date: 2006-11-06 11:51:07 +0000;  author: julliard;  state: Exp;  lines: +10 -15;
>   Damjan Jovanovic <damjan.jov at gmail.com>
>   icmp: Changed select to poll.

Could we just revert this patch? I think poll is not a valid api on
win32 so this breaks the windows port. I don't really see the need in
this change here in the first place.

Thanks
-- 
Steven Edwards

"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo



More information about the wine-patches mailing list