dlls/user32/edit.c -- remove superflous check (RESEND)

Gerald Pfeifer gerald at pfeifer.com
Wed Dec 26 03:00:18 CST 2007


dwBufLen already indictes that this variable is of type DWORD and
thus always positive.  I also looked at the implementation of 
ImmGetCompositionStringW() and we do not seem to return a negative
value (such as -1).

Gerald

ChangeLog:
Remove superflous check in EDIT_GetCompositionStr().

Index: dlls/user32/edit.c
===================================================================
RCS file: /home/wine/wine/dlls/user32/edit.c,v
retrieving revision 1.16
diff -u -3 -p -r1.16 edit.c
--- dlls/user32/edit.c	20 Nov 2007 16:56:17 -0000	1.16
+++ dlls/user32/edit.c	1 Dec 2007 01:59:51 -0000
@@ -5371,12 +5371,6 @@ static void EDIT_GetCompositionStr(HWND 
 
     dwBufLen = ImmGetCompositionStringW(hIMC, GCS_COMPSTR, NULL, 0);
 
-    if (dwBufLen < 0)
-    {
-        ImmReleaseContext(hwnd, hIMC);
-        return;
-    }
-
     lpCompStr = HeapAlloc(GetProcessHeap(),0,dwBufLen + sizeof(WCHAR));
     if (!lpCompStr)
     {



More information about the wine-patches mailing list