[PATCH] CID72: added NULL check.

Marcus Meissner marcus at jet.franken.de
Mon Feb 5 13:58:22 CST 2007


We check for NULL in one place, so we should check
for it in the other too.

>From Coverity.

Ciao, Marcus
---
 dlls/shlwapi/ordinal.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/shlwapi/ordinal.c b/dlls/shlwapi/ordinal.c
index 68b55b3..2af0b7d 100644
--- a/dlls/shlwapi/ordinal.c
+++ b/dlls/shlwapi/ordinal.c
@@ -2148,7 +2148,7 @@ VOID WINAPI IUnknown_Set(IUnknown **lppD
   if (lppDest)
     IUnknown_AtomicRelease(lppDest); /* Release existing interface */
 
-  if (lpUnknown)
+  if (lppDest && lpUnknown)
   {
     /* Copy */
     IUnknown_AddRef(lpUnknown);
-- 
1.4.3.4



More information about the wine-patches mailing list