[PATCH] check return code of ICreateDevEnum_CreateClassEnumerator
Marcus Meissner
marcus at jet.franken.de
Thu Feb 8 13:29:15 CST 2007
Hi,
Coverity thinks that pEnumCat might be used uninitialized.
I agree.
Ciao, Marcus
---
dlls/quartz/filtermapper.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/dlls/quartz/filtermapper.c b/dlls/quartz/filtermapper.c
index 362de85..3948c1e 100644
--- a/dlls/quartz/filtermapper.c
+++ b/dlls/quartz/filtermapper.c
@@ -893,6 +893,9 @@ static HRESULT WINAPI FilterMapper2_Enum
if (SUCCEEDED(hr))
hr = ICreateDevEnum_CreateClassEnumerator(pCreateDevEnum, &CLSID_ActiveMovieCategories, &pEnumCat, 0);
+ if (!SUCCEEDED(hr))
+ return hr;
+
while (IEnumMoniker_Next(pEnumCat, 1, &pMonikerCat, NULL) == S_OK)
{
IPropertyBag * pPropBagCat = NULL;
--
1.4.3.4
More information about the wine-patches
mailing list