version: Constify a formal parameter of VerQueryValue{A|W}()

Andrew Talbot Andrew.Talbot at talbotville.com
Tue Feb 13 10:46:56 CST 2007


I believe the first two parameters of these functions should be constified.
Unfortunately, my skills only extend to fixing the second parameter, so
that's what I've done.

-- Andy.
---
Changelog:
    version: Constify a formal parameter of VerQueryValue{A|W}().

diff -urN a/dlls/version/info.c b/dlls/version/info.c
--- a/dlls/version/info.c	2006-10-09 12:09:42.000000000 +0100
+++ b/dlls/version/info.c	2007-02-13 16:17:53.000000000 +0000
@@ -752,7 +752,7 @@
 /***********************************************************************
  *           VerQueryValueA              [VERSION.@]
  */
-BOOL WINAPI VerQueryValueA( LPVOID pBlock, LPSTR lpSubBlock,
+BOOL WINAPI VerQueryValueA( LPVOID pBlock, LPCSTR lpSubBlock,
                                LPVOID *lplpBuffer, UINT *puLen )
 {
     static const char rootA[] = "\\";
@@ -799,7 +799,7 @@
 /***********************************************************************
  *           VerQueryValueW              [VERSION.@]
  */
-BOOL WINAPI VerQueryValueW( LPVOID pBlock, LPWSTR lpSubBlock,
+BOOL WINAPI VerQueryValueW( LPVOID pBlock, LPCWSTR lpSubBlock,
                                LPVOID *lplpBuffer, UINT *puLen )
 {
     static const WCHAR rootW[] = { '\\', 0 };
diff -urN a/include/winver.h b/include/winver.h
--- a/include/winver.h	2006-05-23 13:49:05.000000000 +0100
+++ b/include/winver.h	2007-02-13 16:17:41.000000000 +0000
@@ -159,8 +159,8 @@
 DWORD       WINAPI VerLanguageNameA(UINT,LPSTR,UINT);
 DWORD       WINAPI VerLanguageNameW(UINT,LPWSTR,UINT);
 #define     VerLanguageName WINELIB_NAME_AW(VerLanguageName)
-BOOL        WINAPI VerQueryValueA(LPVOID,LPSTR,LPVOID*,UINT*);
-BOOL        WINAPI VerQueryValueW(LPVOID,LPWSTR,LPVOID*,UINT*);
+BOOL        WINAPI VerQueryValueA(LPVOID,LPCSTR,LPVOID*,UINT*);
+BOOL        WINAPI VerQueryValueW(LPVOID,LPCWSTR,LPVOID*,UINT*);
 #define     VerQueryValue WINELIB_NAME_AW(VerQueryValue)
 DWORD       WINAPI GetFileVersionInfoSizeA(LPCSTR,LPDWORD);
 DWORD       WINAPI GetFileVersionInfoSizeW(LPCWSTR,LPDWORD);



More information about the wine-patches mailing list