[7/10] WineD3D: No bounds checking is done on sampler / texture
numbers
Stefan Dösinger
stefan at codeweavers.com
Tue Feb 20 08:57:17 CST 2007
Am Montag 19 Februar 2007 16:19 schrieb H. Verbeet:
> On 19/02/07, Stefan Dösinger <stefan at codeweavers.com> wrote:
> >- if(Sampler > GL_LIMITS(sampler_stages) || Sampler < 0 || Type >
>
> WINED3D_HIGHEST_SAMPLER_STATE || Type < 0) {
>
> This also checked the sampler state, not just the sampler.
I added a test to see if the sampler state is checked too, and neither ddraw,
d3d8 nor d3d9 did checks on the sampler state / texture stage state. I am not
sure if we should commit the test to wine because it could cause invisible
memory corruption in the native d3d object which randomly breaks other tests.
DirectX is incorrect here, because I have a test for lights where the light
type IS checked.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20070220/afd27b65/attachment.pgp
More information about the wine-patches
mailing list