[2/3] WineD3D: Do not perform a NULL check on riid (Coverity)
Stefan Dösinger
stefan at codeweavers.com
Thu Jan 11 17:17:04 CST 2007
Coverity spotted a NULL check which was ignored. Rob suggested not to perform
such a NULL check on internal interfaces.
-------------- next part --------------
From 8c8be99800a56886b910e2c60f42e490534fc9c9 Mon Sep 17 00:00:00 2001
From: Stefan Doesinger <stefan at codeweavers.com>
Date: Thu, 11 Jan 2007 23:23:57 +0100
Subject: [PATCH] WineD3D: Do not perform a NULL check on riid
---
dlls/wined3d/surface.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c
index e7991f6..de263b9 100644
--- a/dlls/wined3d/surface.c
+++ b/dlls/wined3d/surface.c
@@ -188,9 +188,7 @@ HRESULT WINAPI IWineD3DSurfaceImpl_QueryInterface(IWineD3DSurface *iface, REFIID
IWineD3DSurfaceImpl *This = (IWineD3DSurfaceImpl *)iface;
/* Warn ,but be nice about things */
TRACE("(%p)->(%s,%p)\n", This,debugstr_guid(riid),ppobj);
- if (riid == NULL) {
- ERR("Probably FIXME: Calling query interface with NULL riid\n");
- }
+
if (IsEqualGUID(riid, &IID_IUnknown)
|| IsEqualGUID(riid, &IID_IWineD3DBase)
|| IsEqualGUID(riid, &IID_IWineD3DResource)
--
1.4.4.3
More information about the wine-patches
mailing list