[5/6] WineD3D: Do not force dynamic usage on transformed buffers

Stefan Dösinger stefan at codeweavers.com
Fri Jan 12 12:02:36 CST 2007


-------------- next part --------------
From 6357eeab8aba846f623831fa05ff77f78b3cedea Mon Sep 17 00:00:00 2001
From: Stefan Doesinger <stefan at codeweavers.com>
Date: Fri, 12 Jan 2007 16:50:38 +0100
Subject: [PATCH] WineD3D: Do not force dynamic usage for transformed vertex buffers

transformed buffers CAN be useful without beeing dynamic, for example
for drawing a HUD. Furthermore the fvf passed to CreateVertexBuffer is
useless, unless dxversion == 7. So don't pretend to be more clever than
the app
---
 dlls/wined3d/device.c |   11 -----------
 1 files changed, 0 insertions(+), 11 deletions(-)

diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c
index 752c3a9..c64dc33 100644
--- a/dlls/wined3d/device.c
+++ b/dlls/wined3d/device.c
@@ -450,17 +450,6 @@ static void CreateVBO(IWineD3DVertexBufferImpl *object) {
         goto error;
     }
 
-    /* Transformed vertices are horribly inflexible. If the app specifies an
-      * vertex buffer with transformed vertices in default pool without DYNAMIC
-      * usage assume DYNAMIC usage and print a warning. The app will have to update
-      * the vertices regularily for them to be useful
-      */
-    if(((object->fvf & WINED3DFVF_POSITION_MASK) == WINED3DFVF_XYZRHW) &&
-        !(vboUsage & WINED3DUSAGE_DYNAMIC)) {
-        WARN("Application creates a vertex buffer holding transformed vertices which doesn't specify dynamic usage\n");
-        vboUsage |= WINED3DUSAGE_DYNAMIC;
-    }
-
     /* Don't use static, because dx apps tend to update the buffer
       * quite often even if they specify 0 usage
       */
-- 
1.4.4.3



More information about the wine-patches mailing list