crypt32(25/25): Update comments about hash message version numbers

Juan Lang juan.lang at gmail.com
Thu Jul 12 17:27:44 CDT 2007


--Juan
-------------- next part --------------
From 0a0833e61ba390afe214a9f12925c18eec9fc78e Mon Sep 17 00:00:00 2001
From: Juan Lang <juanlang at juan.corp.google.com>
Date: Thu, 12 Jul 2007 15:06:21 -0700
Subject: [PATCH] Update comments about hash message version numbers
---
 dlls/crypt32/msg.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/dlls/crypt32/msg.c b/dlls/crypt32/msg.c
index d8ab55a..e97aa0c 100644
--- a/dlls/crypt32/msg.c
+++ b/dlls/crypt32/msg.c
@@ -348,7 +348,7 @@ static BOOL CRYPT_EncodePKCSDigestedData
     if (ret)
     {
         CRYPT_ALGORITHM_IDENTIFIER algoId = { 0 };
-        DWORD version = 0; /* FIXME */
+        DWORD version = CMSG_HASHED_DATA_PKCS_1_5_VERSION;
         struct AsnEncodeSequenceItem items[7] = { { 0 } };
         DWORD cItem = 0;
         CRYPT_DATA_BLOB hash = { 0, NULL };
@@ -455,9 +455,11 @@ static BOOL CHashEncodeMsg_GetParam(HCRY
             SetLastError(CRYPT_E_MSG_ERROR);
         else
         {
-            /* FIXME: under what circumstances is this CMSG_HASHED_DATA_V2? */
             DWORD version = CMSG_HASHED_DATA_PKCS_1_5_VERSION;
 
+            /* Since the data are always encoded as octets, the version is
+             * always 0 (see rfc3852, section 7)
+             */
             ret = CRYPT_CopyParam(pvData, pcbData, (const BYTE *)&version,
              sizeof(version));
         }
-- 
1.4.1


More information about the wine-patches mailing list