[PATCH try2 1/7] urlmon: Remove FLAG_CALLED_SWITCH, which is now redundant.

Misha Koshelev mk144210 at bcm.edu
Wed Jul 18 19:57:32 CDT 2007


Changes: 
* Tried to use fewer macros. I added CLEAR_CALLED in patch 3 and CHECK_NOT_CALLED in patch 4 but
  went without all the WINE_ALLOW stuff and just left the SET_EXPECT even if we then do a 
  CHECK_NOT_CALLED. If the CLEAR_CALLED and CHECK_NOT_CALLED is still too much, I would appreciate
  some advice on how to not use these macros and still have relatively clean code.
* Patch 1 & 2 are new. Also, instead of just returning S_OK from ::Terminate I just implemented it.

This patch:
The FLAG_CALLED_SWITCH flag was necessary b/c I had incorrectly still allowed Read to call
InternetQueryDataAvailable even if we were pending, but now that this is fixed it is 
unnecessary and in fact can (rarely) lead to dropped data notifications.
---
 dlls/urlmon/http.c |   22 ++++++----------------
 1 files changed, 6 insertions(+), 16 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 6664b5a7c0788c513990ff24b1a0f4e5b90c5ae9.diff
Type: text/x-patch
Size: 1995 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20070718/a2ea0bf9/6664b5a7c0788c513990ff24b1a0f4e5b90c5ae9.bin


More information about the wine-patches mailing list