[PATCH 2/3] urlmon/tests: Fix http protocol tests with absence of BINDF_FROMURLMON to properly expect ReportData.

Misha Koshelev mk144210 at bcm.edu
Thu Jul 26 00:02:17 CDT 2007


Again, thanks to Alexandre for pointing this occasional error out:
protocol.c:404: Test failed: unexpected call ReportData

This to me was fairly apparent immediately to result from the BINDF_FROMURLMON flag absent test.
I had tried to adapt these to the message model used for the flag present test, and in the process
made the SET_EXPECT(ReportData) driven basically by the previous ReportData call. However, this
is not really correct, as ReportData in this case is really driven by the calls to Read that return
E_PENDING (really it can only be the very first call to Read that returns E_PENDING, as after that
it can no longer be clear whether E_PENDING is returned because we are still waiting for a request
complete status or because we have received one and now we have read some data but are waiting for
more).

In any case, this will fix the problem, and conforms on Win98 & WinXP.
---
 dlls/urlmon/tests/protocol.c |   71 +++++++++++++++++++++++++++---------------
 1 files changed, 46 insertions(+), 25 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 57fd81537777ecc38e28aefe7f2d330bbbce3824.diff
Type: text/x-patch
Size: 4713 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20070726/e1c48dec/57fd81537777ecc38e28aefe7f2d330bbbce3824-0001.bin


More information about the wine-patches mailing list