crypt32(10/11): Get rid of attribute certs from signed info, they're not supported anyway

Juan Lang juan.lang at gmail.com
Mon Jul 30 14:20:18 CDT 2007


--Juan
-------------- next part --------------
From f9d63eec9c61ad63c0bc602d56649a8509d10d09 Mon Sep 17 00:00:00 2001
From: Juan Lang <juanlang at juan.corp.google.com>
Date: Mon, 30 Jul 2007 12:09:39 -0700
Subject: [PATCH] Get rid of attribute certs from signed info, they're not supported anyway
---
 dlls/crypt32/crypt32_private.h |    2 --
 dlls/crypt32/encode.c          |    2 --
 dlls/crypt32/msg.c             |   15 ++++++---------
 3 files changed, 6 insertions(+), 13 deletions(-)

diff --git a/dlls/crypt32/crypt32_private.h b/dlls/crypt32/crypt32_private.h
index 14f081f..a7bd2b3 100644
--- a/dlls/crypt32/crypt32_private.h
+++ b/dlls/crypt32/crypt32_private.h
@@ -89,8 +89,6 @@ typedef struct _CRYPT_SIGNED_INFO
     PCERT_BLOB         rgCertEncoded;
     DWORD              cCrlEncoded;
     PCRL_BLOB          rgCrlEncoded;
-    DWORD              cAttrCertEncoded;
-    PCERT_BLOB         rgAttrCertEncoded;
     CRYPT_CONTENT_INFO content;
     DWORD              cSignerInfo;
     PCMSG_SIGNER_INFO  rgSignerInfo;
diff --git a/dlls/crypt32/encode.c b/dlls/crypt32/encode.c
index b653a0d..f01b322 100644
--- a/dlls/crypt32/encode.c
+++ b/dlls/crypt32/encode.c
@@ -3255,8 +3255,6 @@ BOOL CRYPT_AsnEncodePKCSSignedInfo(CRYPT
     DWORD cItem = 1, cSwapped = 0;
     BOOL ret = TRUE;
 
-    if (signedInfo->cAttrCertEncoded)
-        FIXME("unimplemented for attr certs\n");
     if (signedInfo->cSignerInfo)
     {
         digestAlgorithmsSet.cItems = signedInfo->cSignerInfo;
diff --git a/dlls/crypt32/msg.c b/dlls/crypt32/msg.c
index 388821b..54f0636 100644
--- a/dlls/crypt32/msg.c
+++ b/dlls/crypt32/msg.c
@@ -1833,21 +1833,18 @@ static BOOL CDecodeSignedMsg_GetParam(CD
         break;
     case CMSG_ATTR_CERT_COUNT_PARAM:
         if (msg->u.signedInfo)
+        {
+            DWORD attrCertCount = 0;
+
             ret = CRYPT_CopyParam(pvData, pcbData,
-             &msg->u.signedInfo->cAttrCertEncoded, sizeof(DWORD));
+             &attrCertCount, sizeof(DWORD));
+        }
         else
             SetLastError(CRYPT_E_INVALID_MSG_TYPE);
         break;
     case CMSG_ATTR_CERT_PARAM:
         if (msg->u.signedInfo)
-        {
-            if (dwIndex >= msg->u.signedInfo->cAttrCertEncoded)
-                SetLastError(CRYPT_E_INVALID_INDEX);
-            else
-                ret = CRYPT_CopyParam(pvData, pcbData,
-                 msg->u.signedInfo->rgAttrCertEncoded[dwIndex].pbData,
-                 msg->u.signedInfo->rgAttrCertEncoded[dwIndex].cbData);
-        }
+            SetLastError(CRYPT_E_INVALID_INDEX);
         else
             SetLastError(CRYPT_E_INVALID_MSG_TYPE);
         break;
-- 
1.4.1


More information about the wine-patches mailing list