wingdi.h: Multi-character character constants are implementation specific according to the C standard. Use a hex number instead.

Michael Stefaniuc mstefani at redhat.de
Mon Jun 4 16:09:26 CDT 2007


See 879 on http://c0x.coding-guidelines.com/6.4.4.4.html. gcc complains
about multi-character character constants even without having any
warnings turned on. We do not get those warnings in Wine because
PROFILE_LINKED and PROFILE_EMBEDDED aren't used; sparse found them.

gcc seems to just transliterate a multi-character character constant to
a hex number by replacing each character with it's ascii value.
---
 include/wingdi.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/wingdi.h b/include/wingdi.h
index 77ad737..0215922 100644
--- a/include/wingdi.h
+++ b/include/wingdi.h
@@ -1851,8 +1851,8 @@ typedef struct {
     DWORD        bV5Reserved;
 } BITMAPV5HEADER, *LPBITMAPV5HEADER, *PBITMAPV5HEADER;
 
-#define PROFILE_LINKED   'LINK'
-#define PROFILE_EMBEDDED 'MBED'
+#define PROFILE_LINKED   0x4c494e4b     /* 'LINK' */
+#define PROFILE_EMBEDDED 0x4d424544     /* 'MBED' */
 
 
   /* biCompression */
-- 
1.5.0.6


-- 
Michael Stefaniuc               Tel.: +49-711-96437-199
Sr. Network Engineer            Fax.: +49-711-96437-111
Red Hat GmbH                    Email: mstefani at redhat.com
Hauptstaetterstr. 58            http://www.redhat.de/
D-70178 Stuttgart
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20070604/126eec6c/attachment-0001.pgp


More information about the wine-patches mailing list