[PATCH 1/2] winemenubuilder: create/release semaphore only around call to wineshelllink.

Misha Koshelev mk144210 at bcm.edu
Mon Jun 25 19:32:54 CDT 2007


The problem: Many installers (Vector NTI, iTunes) create start menu shortcuts before the actual applications 
or icons have been extracted. Currently, winemenubuilder in this case puts itself into a RunOnce key to be 
run again, but for the installers I described and I am sure lots of others no reboot is needed/triggered by
the installer and thus winemenubuilder is never run again. Thus, to the average user, no menu entries.

This is not a problem with our handling of RunOnce; as far as I am aware we handle all native cases of 
RunOnce keys correctly (an app that sets such a key usu. triggers a reboot, which triggers wineboot).

Thus, I propose the change in this patchset, that is, have winemenubuilder wait for the icon/exe to exist.
In my tests with Vector NTI & iTunes, this works beautifully. Even clicking Cancel after winemenubuilder's
have already been launched does not leave any running processes.
---
 programs/winemenubuilder/winemenubuilder.c |   25 +++++++++++++------------
 1 files changed, 13 insertions(+), 12 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 76eb033c54ffabb6ad7a47669bd6d9bee6e2d728.diff
Type: text/x-patch
Size: 2279 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20070625/2781361c/76eb033c54ffabb6ad7a47669bd6d9bee6e2d728.bin


More information about the wine-patches mailing list