[advapi32/service #2] Don't rely blindly on type (Resend)

Paul Vriens paul.vriens.wine at gmail.com
Thu Jun 28 01:02:54 CDT 2007


Hi,

(Thanks to Rolf Kalbermatter for pointing out I was a bit to cautious here)

On Wine, type is unchanged in a failure case for RegQueryValueExW. This means
the previous code relied on the returned type of the previous last succeeded
call, huh?

I've checked on Windows and a failure case for RegQueryValueExW leads to a
random type on NT4, 0 on W2K/XP/W2K3 and an apparently fixed '92' on vista. So I
think we don't have to change our RegQueryValueExW for that.

Changed all the '||' into '&&' as that makes more sense. I will check on Windows
if there are any restrictions and change (or delete) the checks accordingly.

Changelog
       Don't rely blindly on type

Cheers,

Paul.




-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Don-t-rely-blindly-on-type.patch
Type: text/x-patch
Size: 3007 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20070628/72c60cb9/0003-Don-t-rely-blindly-on-type.bin


More information about the wine-patches mailing list