[PATCH] ppinhandler might be used uninitialized

Marcus Meissner marcus at jet.franken.de
Fri Mar 2 14:28:47 CST 2007


Hi,

spotted by coverity.

Ciao, Marcus
---
 dlls/quartz/filtergraph.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/dlls/quartz/filtergraph.c b/dlls/quartz/filtergraph.c
index 36767a0..260a381 100644
--- a/dlls/quartz/filtergraph.c
+++ b/dlls/quartz/filtergraph.c
@@ -964,7 +964,7 @@ static HRESULT WINAPI GraphBuilder_Rende
     IBaseFilter* preader = NULL;
     IBaseFilter* psplitter = NULL;
     IPin* ppinreader;
-    IPin* ppinsplitter;
+    IPin* ppinsplitter = NULL;
     IEnumPins* penumpins;
     ULONG pin;
     HRESULT hr;
@@ -1065,7 +1065,8 @@ static HRESULT WINAPI GraphBuilder_Rende
             }
         }
 
-        IPin_Release(ppinsplitter);
+        if (ppinsplitter)
+            IPin_Release(ppinsplitter);
         ppinsplitter = NULL;
 
         if (SUCCEEDED(hr)) {
-- 
1.4.3.4



More information about the wine-patches mailing list