quartz: Check allocation failure and clear memory in DSound Renderer
Chris Robinson
chris.kcat at gmail.com
Fri Mar 9 05:02:31 CST 2007
-------------- next part --------------
From 2650a3fd9b86a01780ae6829d4f2dcb26b751c0b Mon Sep 17 00:00:00 2001
From: Chris Robinson <chris.kcat at gmail.com>
Date: Fri, 9 Mar 2007 02:59:50 -0800
Subject: [PATCH] quartz: Check allocation failure and clear memory in DSound Renderer
---
dlls/quartz/dsoundrender.c | 11 ++++++++++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/dlls/quartz/dsoundrender.c b/dlls/quartz/dsoundrender.c
index fe6152f..d56a117 100644
--- a/dlls/quartz/dsoundrender.c
+++ b/dlls/quartz/dsoundrender.c
@@ -316,6 +316,9 @@ HRESULT DSoundRender_create(IUnknown * pUnkOuter, LPVOID * ppv)
return CLASS_E_NOAGGREGATION;
pDSoundRender = CoTaskMemAlloc(sizeof(DSoundRenderImpl));
+ if (!pDSoundRender)
+ return E_OUTOFMEMORY;
+ ZeroMemory(pDSoundRender, sizeof(DSoundRenderImpl));
pDSoundRender->lpVtbl = &DSoundRender_Vtbl;
pDSoundRender->IBasicAudio_vtbl = &IBasicAudio_Vtbl;
@@ -325,9 +328,15 @@ HRESULT DSoundRender_create(IUnknown * pUnkOuter, LPVOID * ppv)
pDSoundRender->pClock = NULL;
pDSoundRender->init = FALSE;
pDSoundRender->started = FALSE;
- ZeroMemory(&pDSoundRender->filterInfo, sizeof(FILTER_INFO));
pDSoundRender->ppPins = CoTaskMemAlloc(1 * sizeof(IPin *));
+ if (!pDSoundRender->ppPins)
+ {
+ DeleteCriticalSection(&pDSoundRender->csFilter);
+ CoTaskMemFree(pDSoundRender);
+ return E_OUTOFMEMORY;
+ }
+ ZeroMemory(pDSoundRender->ppPins, 1 * sizeof(IPin *));
/* construct input pin */
piInput.dir = PINDIR_INPUT;
--
1.4.4.4
More information about the wine-patches
mailing list