Makefiles: Be less verbose when performing make rules by only printing the command being executed and the source and/or target file.

Robert Shearman rob at codeweavers.com
Wed Mar 14 10:43:09 CDT 2007


The old behaviour can be turned back on by setting the V environment 
variable to "1" (e.g. make V=1).
---
  Make.rules.in              |   39 ++++++++++++++++++++-------------------
  dlls/Makedll.rules.in      |    2 +-
  dlls/Makeimplib.rules.in   |    6 +++---
  dlls/Maketest.rules.in     |   12 ++++++------
  programs/Makeprog.rules.in |    4 ++--
  tools/makerule             |   25 +++++++++++++++++++++++++
  6 files changed, 57 insertions(+), 31 deletions(-)
  create mode 100755 tools/makerule

This patch has been update to take into account Eric's comment about a 
command that would no longer be shown, even with V=1 and also to output 
a failing command line when not in verbose mode, as shown by this example:
[CC] cproxy.c
[CC] cpsf.c
[CC] cstub.c
[CC] ndr_clientserver.c
[CC] ndr_fullpointer.c
[CC] ndr_marshall.c
[CC] ndr_ole.c
[CC] ndr_stubless.c
[CC] rpc_binding.c
[CC] rpc_epmap.c
[CC] rpc_message.c
[CC] rpc_server.c
[CC] rpc_transport.c
rpc_transport.c: In function ‘rpcrt4_conn_np_alloc’:
rpc_transport.c:109: error: ‘struct _RpcConnection_np’ has no member 
named ‘foo’
The command that failed was:
gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_RPCRT4_ 
-DCOM_NO_WINDOWS_H -DMSWMSG -D_REENTRANT -fPIC -Wall -pipe 
-fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings 
-Wpointer-arith -g -O2 -o rpc_transport.o rpc_transport.c

I've also modified tools/makerule to respect the "-s" flag passed into make.

Alexandre suggested on IRC that I always print the destination file, but 
  I want to make sure that the technical details of this patch are 
acceptable before making tweaks to the printed commands.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 445b03b30f47f4292eade69cfb4b3c0901e6bf00.diff
Type: text/x-patch
Size: 7804 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20070314/39be2f0f/445b03b30f47f4292eade69cfb4b3c0901e6bf00.bin


More information about the wine-patches mailing list