dlls/user32/scroll.c -- two type related fixes

Gerald Pfeifer gerald at pfeifer.com
Wed Nov 21 04:25:09 CST 2007


Unlike all recent changes this variable actually should be signed, not
unsigned.  The second is another case of checking an unsigned value for
being >= 0 (and I didn't see -1 assignments for an error case).

Gerald

ChangeLog:
Fix variable type in SCROLL_HandleScrollEvent().  Remove useless
check in SCROLL_SetScrollInfo().

Index: dlls/user32/scroll.c
===================================================================
RCS file: /home/wine/wine/dlls/user32/scroll.c,v
retrieving revision 1.5
diff -u -3 -p -r1.5 scroll.c
--- dlls/user32/scroll.c	13 Nov 2007 14:36:02 -0000	1.5
+++ dlls/user32/scroll.c	21 Nov 2007 10:19:43 -0000
@@ -961,7 +961,7 @@ static void SCROLL_HandleScrollEvent( HW
         }
         else  /* WM_MOUSEMOVE */
         {
-            UINT pos;
+            INT pos;
 
             if (!SCROLL_PtInRectEx( &rect, pt, vertical )) pos = lastClickPos;
             else
@@ -1621,7 +1621,7 @@ static INT SCROLL_SetScrollInfo( HWND hw
 
     if (info->fMask & SIF_PAGE)
     {
-	if( infoPtr->page != info->nPage && info->nPage >= 0)
+	if( infoPtr->page != info->nPage )
 	{
             infoPtr->page = info->nPage;
             action |= SA_SSI_REFRESH;



More information about the wine-patches mailing list