dlls/inetcomm/internettransport.c -- fix error check

Gerald Pfeifer gerald at pfeifer.com
Fri Nov 23 13:57:58 CST 2007


This check would never trigger as currently written.

Gerald

ChangeLog:
Fix error check in InternetTransport_Connect().

Index: dlls/inetcomm/internettransport.c
===================================================================
RCS file: /home/wine/wine/dlls/inetcomm/internettransport.c,v
retrieving revision 1.2
diff -u -3 -p -r1.2 internettransport.c
--- dlls/inetcomm/internettransport.c	5 Nov 2007 14:26:51 -0000	1.2
+++ dlls/inetcomm/internettransport.c	23 Nov 2007 19:56:52 -0000
@@ -110,6 +110,8 @@ HRESULT InternetTransport_Connect(Intern
 
     for (ai_cur = ai; ai_cur; ai_cur = ai->ai_next)
     {
+        int so;
+
         if (TRACE_ON(inetcomm))
         {
             char host[256];
@@ -122,12 +124,13 @@ HRESULT InternetTransport_Connect(Intern
 
         InternetTransport_ChangeStatus(This, IXP_CONNECTING);
 
-        This->Socket = socket(ai_cur->ai_family, ai_cur->ai_socktype, ai_cur->ai_protocol);
-        if (This->Socket < 0)
+        so = socket(ai_cur->ai_family, ai_cur->ai_socktype, ai_cur->ai_protocol);
+        if (so == -1)
         {
             WARN("socket() failed\n");
             continue;
         }
+        This->Socket = so;
 
         /* FIXME: set to async */
 



More information about the wine-patches mailing list