comctl32/header.c -- remove extraneous check

Gerald Pfeifer gerald at pfeifer.com
Fri Nov 30 17:44:09 CST 2007


I tried to check whether this actually should read "wParam == -1" (that
is, error handling instead of out of range handling) but couldn't find 
evidence.  Just wanted to point this out in case!

Gerald

ChangeLog:
Remove extraneous check (unsigned < 0).

Index: dlls/comctl32/header.c
===================================================================
RCS file: /home/wine/wine/dlls/comctl32/header.c,v
retrieving revision 1.143
diff -u -3 -p -r1.143 header.c
--- dlls/comctl32/header.c	25 May 2007 19:46:02 -0000	1.143
+++ dlls/comctl32/header.c	30 Nov 2007 21:03:34 -0000
@@ -981,7 +981,7 @@ HEADER_CreateDragImage (HWND hwnd, WPARA
     int height, width;
     HFONT hFont;
     
-    if (wParam < 0 || wParam >= infoPtr->uNumItem)
+    if (wParam >= infoPtr->uNumItem)
         return FALSE;
 
     if (!infoPtr->bRectsValid)



More information about the wine-patches mailing list