ntdll: RtlCreateAcl: initialize all the bytes passed by the user

Dan Kegel dank at kegel.com
Mon Oct 29 15:24:26 CDT 2007


Without this patch, NtAccessCheck() references uninitialized
memory (it seems to send the entire ACL with the user's
length to the server, not just sizeof(ACL)).  This showed up as
valgrind errors when running "make test" in advapi32.
I suppose the right fix might be to send just sizeof(ACL) bytes
to the server, but I wouldn't know, and initializing all
the bytes given by the caller seems innocuous enough.

Also fix a probably level-of-indirection thinko in a TRACE
that causes a valgrind error with +ntdll.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dacl.patch
Type: text/x-patch
Size: 759 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20071029/39c18554/attachment.bin 


More information about the wine-patches mailing list