wininet: Don't release the parent object in FTP_Connect, the caller will do that.

Hans Leidekker hans at it.vu.nl
Tue Oct 30 07:30:47 CDT 2007


Lionel Debroux reported a crash while running the ftp test with local
network interfaces down. A trace revealed that this condition triggers
a refcounting bug: We release the parent object on failure in FTP_Connect
but the caller also releases it, triggering its destruction at that point.
Later, when InternetCloseHandle is called, that parent is accessed again..

Applies after the patch named "wininet: Use a single connection for
all ftp tests."

See http://bugs.winehq.org/show_bug.cgi?id=9916

 -Hans

Changelog
 Don't release the parent object in FTP_Connect, the caller will do that.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wininet_ftp_refcount.diff
Type: text/x-diff
Size: 1789 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20071030/39dfec9c/attachment.diff 


More information about the wine-patches mailing list