[PATCH] Implement D3DXMatrixfDeterminant with a test Please enter the commit message for your changes.

[David Adam]

---
 dlls/d3dx8/d3dx8.spec   |    2 +-
 dlls/d3dx8/math.c       |   15 +++++++++++++++
 dlls/d3dx8/tests/math.c |   19 +++++++++++++------
 include/d3dx8math.h     |    2 ++
 4 files changed, 31 insertions(+), 7 deletions(-)

diff --git a/dlls/d3dx8/d3dx8.spec b/dlls/d3dx8/d3dx8.spec
index a64e1e4..d08fb9f 100644
--- a/dlls/d3dx8/d3dx8.spec
+++ b/dlls/d3dx8/d3dx8.spec
@@ -20,7 +20,7 @@
 @ stdcall D3DXVec4CatmullRom(ptr ptr ptr ptr long)
 @ stdcall D3DXVec4BaryCentric(ptr ptr ptr ptr long long)
 @ stdcall D3DXVec4Transform(ptr ptr ptr)
-@ stub D3DXMatrixfDeterminant
+@ stdcall D3DXMatrixfDeterminant(ptr)
 @ stub D3DXMatrixMultiply
 @ stub D3DXMatrixTranspose
 @ stub D3DXMatrixInverse
diff --git a/dlls/d3dx8/math.c b/dlls/d3dx8/math.c
index ff1b493..fa1a49e 100644
--- a/dlls/d3dx8/math.c
+++ b/dlls/d3dx8/math.c
@@ -29,6 +29,21 @@
=20
 WINE_DEFAULT_DEBUG_CHANNEL(d3dx8);
=20
+/*_________________D3DXMatrix____________________*/
+
+FLOAT WINAPI D3DXMatrixfDeterminant(CONST D3DXMATRIX *pm)
+{
+    D3DXVECTOR4 minor, v1, v2, v3;
+    FLOAT det;
+
+    v1.x =3D pm->m[0][0]; v1.y =3D pm->m[1][0]; v1.z =3D pm->m[2][0]; v1.w =
=3D pm->m[3][0];
+    v2.x =3D pm->m[0][1]; v2.y =3D pm->m[1][1]; v2.z =3D pm->m[2][1]; v2.w =
=3D pm->m[3][1];
+    v3.x =3D pm->m[0][2]; v3.y =3D pm->m[1][2]; v3.z =3D pm->m[2][2]; v3.w =
=3D pm->m[3][2];
+    D3DXVec4Cross(&minor,&v1,&v2,&v3);
+    det =3D  - (pm->m[0][3] * minor.x + pm->m[1][3] * minor.y + pm->m[2][3]=
 * minor.z + pm->m[3][3] * minor.w);
+    return det;
+}
+
 /*_________________D3DXQUATERNION________________*/
=20
 D3DXQUATERNION* WINAPI D3DXQuaternionNormalize(D3DXQUATERNION *pout, CONST =
D3DXQUATERNION *pq)
diff --git a/dlls/d3dx8/tests/math.c b/dlls/d3dx8/tests/math.c
index 33a60dc..cda666a 100644
--- a/dlls/d3dx8/tests/math.c
+++ b/dlls/d3dx8/tests/math.c
@@ -125,14 +125,21 @@ static void D3DXMatrixTest(void)
 {
     D3DXMATRIX mat;
     BOOL expected, got;
+    FLOAT expectedfloat, gotfloat;
+
+    U(mat).m[0][1] =3D 5.0f; U(mat).m[0][2] =3D 7.0f; U(mat).m[0][3] =3D 8.=
0f;
+    U(mat).m[1][0] =3D 11.0f; U(mat).m[1][2] =3D 16.0f; U(mat).m[1][3] =3D =
33.0f;
+    U(mat).m[2][0] =3D 19.0f; U(mat).m[2][1] =3D -21.0f; U(mat).m[2][3] =3D=
 43.0f;
+    U(mat).m[3][0] =3D 2.0f; U(mat).m[3][1] =3D 3.0f; U(mat).m[3][2] =3D -4=
.0f;
+    U(mat).m[0][0] =3D 10.0f; U(mat).m[1][1] =3D 20.0f; U(mat).m[2][2] =3D =
30.0f;
+    U(mat).m[3][3] =3D -40.0f;
+
+/*____________D3DXMatrixfDeterminant_____________*/
+    expectedfloat =3D -147888.0f;
+    gotfloat =3D D3DXMatrixfDeterminant(&mat);
+    ok(fabs( gotfloat - expectedfloat ) < admitted_error, "Expected: %f, Go=
t: %f\n", expectedfloat, gotfloat);
=20
 /*____________D3DXMatrixIsIdentity______________*/
-    U(mat).m[0][1] =3D 0.0f; U(mat).m[0][2] =3D 7.0f; U(mat).m[0][3] =3D 8.=
0f;
-    U(mat).m[1][0] =3D 11.0f; U(mat).m[1][2] =3D 0.0f; U(mat).m[1][3] =3D 0=
.0f;
-    U(mat).m[2][0] =3D 0.0f; U(mat).m[2][1] =3D 0.0f; U(mat).m[2][3] =3D 0.=
0f;
-    U(mat).m[3][0] =3D 0.0f; U(mat).m[3][1] =3D 0.0f; U(mat).m[3][2] =3D 0.=
0f;
-    U(mat).m[0][0] =3D 1.0f; U(mat).m[1][1] =3D 1.0f; U(mat).m[2][2] =3D 1.=
0f;
-    U(mat).m[3][3] =3D 1.0f;
     expected =3D FALSE;
     got =3D D3DXMatrixIsIdentity(&mat);
     ok(expected =3D=3D got, "Expected : %d, Got : %d\n", expected, got);
diff --git a/include/d3dx8math.h b/include/d3dx8math.h
index a5fc09e..9dcf0a4 100644
--- a/include/d3dx8math.h
+++ b/include/d3dx8math.h
@@ -58,6 +58,8 @@ typedef struct D3DXCOLOR
     FLOAT r, g, b, a;
 } D3DXCOLOR, *LPD3DXCOLOR;
=20
+FLOAT WINAPI D3DXMatrixfDeterminant(CONST D3DXMATRIX *pm);
+
 D3DXQUATERNION* WINAPI D3DXQuaternionNormalize(D3DXQUATERNION *pout, CONST =
D3DXQUATERNION *pq);
=20
 D3DXVECTOR2* WINAPI D3DXVec2BaryCentric(D3DXVECTOR2 *pout, CONST D3DXVECTOR=
2 *pv1, CONST D3DXVECTOR2 *pv2, CONST D3DXVECTOR2 *pv3, FLOAT f, FLOAT g);
--=20
1.5.3.2


--=_4e4gx1v5xl0k--