ntdll: NtAccessCheck: only send used bytes to server (try 2)

Dan Kegel dank at kegel.com
Wed Oct 31 01:17:31 CDT 2007


Without this patch, NtAccessCheck() sent the user's entire ACL
buffer to the server, including the uninitialized section.
This caused valgrind errors when running "make test" in advapi32,
and could conceivably cause performance problems on
apps that have unreasonably large acl buffers.

This time I did the right fix, i.e. send just the used bytes
to the server.  I think this is what Alexandre wanted.
I hesitated to do it before since I don't really understand
this code, but now that I've done it, it doesn't seem so scary.
(Not that I understand the code any better -- I didn't look at
the server end at all, for instance.)

Also fix a probably level-of-indirection thinko in a TRACE
and another typo in a WARN that cause valgrind errors with +ntdll.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ntdll.patch
Type: text/x-patch
Size: 3719 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20071030/5ecb087f/attachment-0001.bin 


More information about the wine-patches mailing list