crypt32(16/17): Flags weren't set, so don't bother passing them

Juan Lang juan.lang at gmail.com
Thu Sep 6 12:10:14 CDT 2007


--Juan
-------------- next part --------------
From 3874fa14bc1772191978e3458cea2d660c10eb41 Mon Sep 17 00:00:00 2001
From: Juan Lang <juan.lang at gmail.com>
Date: Thu, 6 Sep 2007 10:02:33 -0700
Subject: [PATCH] Flags weren't set, so don't bother passing them
---
 dlls/crypt32/chain.c |   20 +++-----------------
 1 files changed, 3 insertions(+), 17 deletions(-)

diff --git a/dlls/crypt32/chain.c b/dlls/crypt32/chain.c
index 98b69b9..8d0d78c 100644
--- a/dlls/crypt32/chain.c
+++ b/dlls/crypt32/chain.c
@@ -264,7 +264,7 @@ static inline void CRYPT_CombineTrustSta
 }
 
 static BOOL CRYPT_AddCertToSimpleChain(PCertificateChainEngine engine,
- PCERT_SIMPLE_CHAIN chain, PCCERT_CONTEXT cert, DWORD dwFlags)
+ PCERT_SIMPLE_CHAIN chain, PCCERT_CONTEXT cert)
 {
     BOOL ret = FALSE;
     PCERT_CHAIN_ELEMENT element = CryptMemAlloc(sizeof(CERT_CHAIN_ELEMENT));
@@ -282,20 +282,6 @@ static BOOL CRYPT_AddCertToSimpleChain(P
             memset(element, 0, sizeof(CERT_CHAIN_ELEMENT));
             element->cbSize = sizeof(CERT_CHAIN_ELEMENT);
             element->pCertContext = CertDuplicateCertificateContext(cert);
-            /* Flags, if set, refer to the element this cert issued, so set
-             * the preceding element's error accordingly
-             */
-            if (chain->cElement > 1)
-            {
-                if (dwFlags & CERT_STORE_REVOCATION_FLAG &&
-                 !(dwFlags & CERT_STORE_NO_CRL_FLAG))
-                    chain->rgpElement[chain->cElement - 2]->TrustStatus.
-                     dwErrorStatus |= CERT_TRUST_IS_REVOKED;
-                if (dwFlags & CERT_STORE_SIGNATURE_FLAG)
-                    chain->rgpElement[chain->cElement - 2]->TrustStatus.
-                     dwErrorStatus |=
-                     CERT_TRUST_IS_NOT_SIGNATURE_VALID;
-            }
             /* FIXME: initialize the rest of element */
             if (chain->cElement % engine->CycleDetectionModulus)
                 CRYPT_CheckSimpleChainForCycles(chain);
@@ -529,7 +515,7 @@ static BOOL CRYPT_BuildSimpleChain(PCert
 
         if (issuer)
         {
-            ret = CRYPT_AddCertToSimpleChain(engine, chain, issuer, flags);
+            ret = CRYPT_AddCertToSimpleChain(engine, chain, issuer);
             cert = issuer;
         }
         else
@@ -555,7 +541,7 @@ static BOOL CRYPT_GetSimpleChainForCert(
     {
         memset(chain, 0, sizeof(CERT_SIMPLE_CHAIN));
         chain->cbSize = sizeof(CERT_SIMPLE_CHAIN);
-        ret = CRYPT_AddCertToSimpleChain(engine, chain, cert, 0);
+        ret = CRYPT_AddCertToSimpleChain(engine, chain, cert);
         if (ret)
         {
             ret = CRYPT_BuildSimpleChain(engine, world, chain);
-- 
1.4.1


More information about the wine-patches mailing list