dlls/d3d9/tests/visual.c cleanup

Stefan Dösinger stefan at codeweavers.com
Tue Apr 8 15:46:58 CDT 2008


Am Dienstag, 8. April 2008 18:08:15 schrieb Gerald Pfeifer:
> On Mon, 14 Jan 2008, Alexandre Julliard wrote:
> > These tests don't make much sense, with or without your fix, plus the
> > error messages don't match the tests. This needs more work.
>
> It seems this was added with 2007-11-07 with the following log entry:
>
>   Stefan Dösinger <stefan at codeweavers.com>
>   wined3d: Shader Model 3.0 varying tests.
>
> I've seen patches in this area cleaning up some stuff.  Does this
> address the issues you were seeing?  Otherwise, I'd hope Stefan can
> have a look.
>
> Here is an updated patch of mine.
The patch should be OK as it is a NOP functionally. I wonder why it is needed 
though, since I think that if all 3 lines look the same they're easier to 
read, but beauty is arguable. Does the patch fix some compiler warnings with 
some extra warnings enabled?






More information about the wine-patches mailing list