[PATCH] handle exit path where bind not allocated yet
Marcus Meissner
marcus at jet.franken.de
Wed Apr 16 01:37:26 CDT 2008
Hi,
Two new things spotted by Coverity which pointed
to potential NULL ptr derference in the error path.
I added early error returns before bind allocation.
Ciao, Marcus
---
dlls/rpcrt4/rpc_binding.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/dlls/rpcrt4/rpc_binding.c b/dlls/rpcrt4/rpc_binding.c
index d670a88..84e63c3 100644
--- a/dlls/rpcrt4/rpc_binding.c
+++ b/dlls/rpcrt4/rpc_binding.c
@@ -725,6 +725,8 @@ RPC_STATUS WINAPI RpcBindingFromStringBindingA( RPC_CSTR StringBinding, RPC_BIND
if (ret == RPC_S_OK)
ret = RPCRT4_CreateBindingA(&bind, FALSE, (char*)Protseq);
+ if (ret != RPC_S_OK) return ret;
+
if (ret == RPC_S_OK)
ret = RPCRT4_SetBindingObject(bind, &Uuid);
if (ret == RPC_S_OK)
@@ -764,6 +766,8 @@ RPC_STATUS WINAPI RpcBindingFromStringBindingW( RPC_WSTR StringBinding, RPC_BIND
if (ret == RPC_S_OK)
ret = RPCRT4_CreateBindingW(&bind, FALSE, Protseq);
+ if (ret != RPC_S_OK) return ret;
+
if (ret == RPC_S_OK)
ret = RPCRT4_SetBindingObject(bind, &Uuid);
if (ret == RPC_S_OK)
--
1.5.2.4
More information about the wine-patches
mailing list