[PATCH] initialize hLock

Marcus Meissner marcus at jet.franken.de
Wed Apr 16 01:41:54 CDT 2008


Hi,

Coverity thinks a uninitialized hLock return might be possible...

Generally I do not think so, but making it clearer in the code
cannot hurt.

Ciao, Marcus
---
 dlls/advapi32/service.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/advapi32/service.c b/dlls/advapi32/service.c
index dc44e6f..f9115c2 100644
--- a/dlls/advapi32/service.c
+++ b/dlls/advapi32/service.c
@@ -669,7 +669,7 @@ BOOL WINAPI StartServiceCtrlDispatcherW( const SERVICE_TABLE_ENTRYW *servent )
 SC_LOCK WINAPI LockServiceDatabase (SC_HANDLE hSCManager)
 {
     struct sc_manager *hscm;
-    SC_RPC_LOCK hLock;
+    SC_RPC_LOCK hLock = NULL;
     DWORD err;
 
     TRACE("%p\n",hSCManager);
-- 
1.5.2.4



More information about the wine-patches mailing list