[resend] [Try 4] [1/2] cabinet.dll -> FDICopy: Test added

Vitaly Perov vitperov at etersoft.ru
Tue Apr 29 07:33:22 CDT 2008


jhawkins at codeweavers.com : cabinet: Revert "cabinet: Fix for FDICopy with an 
empty cabinet file."
> Hi,
>
>  The test was incorrect and failed on all platforms.  Vitaly, please
>  ask someone to test your patches on a real windows system in the
>  future if you don't have access to one.

I have tested this patch on Win98. It didn't failed.
But on WinXP it failed.

The pach comes with this test fix a problem, so installation of certain 
software (it includes one empty cab-file ) doesn't fail anymore.
I don't think, that this patch can cause any problem with a software developed 
for WinXP.

So, please look it trough once more.


Description:
This test checks if function FDICopy() of cabinet.dll correctly works with an 
empty cabinet file (It's correct cab-file, but it has no files and folders 
inside).
In this case Windows return TRUE, but WINE return FALSE. So the installation 
of certain software finishes with an error in WINE

Changelog:
    - Added a test for cabinet.dll FDICopy function. This test checks if it              
works correctly with an empty cab-files

-- 
Best wishes,
Vitaly Perov
Russia, Saint-Petersburg. www.etersoft.ru
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tests-cabinet-test_FDICopy-empty_cab_file.patch
Type: text/x-diff
Size: 1617 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20080429/912763f3/attachment.patch 


More information about the wine-patches mailing list