winemaker: Correctly process directories containing regexp metacharacters

Simon C. Ion ion.simon.c at gmail.com
Fri Dec 19 18:23:45 CST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Directories with regexp metacharacters in them (like '+') cause some
regexp operation on line 1106 to fail .
The attached patch escapes metacharacters in path component in the
'search_from' function.

Reproduction recipe:

1) Download QT 4.3.1 (Win32) and unpack. [1]
2) cd to qt-win-opensource-src-4.3.1.
3) Run 'winemaker'.

It'll churn for a while, then you get this message:
Nested quantifiers in regex; marked by <-- HERE in m/^linux-g++ <-- HERE
$/ at
/usr/local/bin/winemaker line 1106, <FILEI> line 39.


[1] QT is here:
ftp://ftp.trolltech.com/qt/source/qt-win-opensource-src-4.3.1.zip


This patch currently applies cleanly to git HEAD.


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iQEcBAEBAgAGBQJJTDsMAAoJEEtxx6PkYe4khUUH/ArULBYh11DL1vO1+wOO17zc
ksdy+pjfw3+xCoie72h92Y+pUz3+6E7zcUv1sjWcbdBxckOifIU8ZXQMRt9V1JYm
p5WjnUVDwWzVUW7By+tf/d9OKb3+zLngDHxkxoOfAEsawTwduWjoAdRzICFZo47N
2hf9rn8Y3Bsn+6afAEIJFkaU+KGjU4AmbgcSqj7ld+hbGrwtQD6C3rqJ0CyOmx/h
g6+cjFUiuKD77c7gzxsL9sCbXu25UCF9XWxjVIBsll9VSfX5kOSlOBue5dNc/IdB
YG70abSzdZmczO/b6bc2owjTyETTCX68jvJl7pf0mw2zXdon+z3G7ChcaWxYHtU=
=NcKU
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: winemakerRegexp.patch
Url: http://www.winehq.org/pipermail/wine-patches/attachments/20081219/976acd5e/attachment-0001.txt 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: winemakerRegexp.patch.sig
Type: application/octet-stream
Size: 287 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20081219/976acd5e/attachment-0001.obj 


More information about the wine-patches mailing list