d3d: Add a slight delay before testing the ddraw and d3d9 visual tests
Peter Dons Tychsen
donpedro at tdcadsl.dk
Tue Feb 12 20:11:24 CST 2008
Eh, this does not seem like a proper way to get a unit test to pass.
Sleep()... that leads to the dark side! :-)
Why does it need a Sleep()? If its failing on Wine, then shouldn't it be
fixed in the libs? And if its on orig-winxp-vista then there must be a
better way to wait? Or no?
The string "This makes the tests pass on my pc" isn't very good either.
In general, introducing magic Sleep() values in code is not a good idea.
If the test system is stressed, you will start getting failures again =
On Wed, 2008-02-13 at 02:26 +0100, Stefan Dösinger wrote:
> Am Mittwoch, 13. Februar 2008 02:25:30 schrieb Maarten Lankhorst:
> > This makes the tests pass on my pc.
> d3d8 might need it as well
More information about the wine-patches