dlls/shell32/pidl.c -- adjust to unsignedness of a type

Gerald Pfeifer gerald at pfeifer.com
Wed Feb 13 19:22:15 CST 2008


This I spotted when building with GCC 4.3.  The adjustment of the 
format string is in line what we have a few lines below that point.

Gerald

ChangeLog:
Adjust a format specifier and range check to the unsignedness of a
type in ILGetDisplayNameExW().

Index: dlls/shell32/pidl.c
===================================================================
RCS file: /home/wine/wine/dlls/shell32/pidl.c,v
retrieving revision 1.158
diff -u -3 -p -r1.158 pidl.c
--- dlls/shell32/pidl.c	16 Jan 2008 13:11:25 -0000	1.158
+++ dlls/shell32/pidl.c	13 Feb 2008 23:56:25 -0000
@@ -97,7 +97,7 @@ BOOL WINAPI ILGetDisplayNameExW(LPSHELLF
     STRRET strret;
     DWORD flag;
 
-    TRACE("%p %p %p %d\n", psf, pidl, path, type);
+    TRACE("%p %p %p %x\n", psf, pidl, path, type);
 
     if (!pidl || !path)
         return FALSE;
@@ -109,7 +109,7 @@ BOOL WINAPI ILGetDisplayNameExW(LPSHELLF
             return FALSE;
     }
 
-    if (type >= 0 && type <= 2)
+    if (type <= 2)
     {
         switch (type)
         {



More information about the wine-patches mailing list