dmband: Rename identifiers to remove false implications of type

Andrew Talbot andrew.talbot at talbotville.com
Thu Feb 21 16:11:31 CST 2008


The leading "p" in each of these names implies a degree of pointing that
doesn't appear to exist.

-- Andy.
---
Changelog:
   dmband: Rename identifiers to remove false implications of type.

diff --git a/dlls/dmband/bandtrack.c b/dlls/dmband/bandtrack.c
index ccb0c69..f85d096 100644
--- a/dlls/dmband/bandtrack.c
+++ b/dlls/dmband/bandtrack.c
@@ -302,8 +302,8 @@ static HRESULT IDirectMusicBandTrack_IPersistStream_LoadBand (LPPERSISTSTREAM if
       ERR(": no more memory\n");
       return  E_OUTOFMEMORY;
     }
-    memcpy(&pNewBand->pBandHeader, pHeader, sizeof(DMUS_PRIVATE_BAND_ITEM_HEADER));
-    pNewBand->ppBand = (IDirectMusicBandImpl*)((char*)(*ppBand) - offsetof(IDirectMusicBandImpl,BandVtbl));
+    memcpy(&pNewBand->BandHeader, pHeader, sizeof(DMUS_PRIVATE_BAND_ITEM_HEADER));
+    pNewBand->pBand = (IDirectMusicBandImpl*)((char*)(*ppBand) - offsetof(IDirectMusicBandImpl,BandVtbl));
     IDirectMusicBand_AddRef(*ppBand);
     list_add_tail (&This->Bands, &pNewBand->entry);
   }
diff --git a/dlls/dmband/dmband_private.h b/dlls/dmband/dmband_private.h
index f18f8f4..46a4d07 100644
--- a/dlls/dmband/dmband_private.h
+++ b/dlls/dmband/dmband_private.h
@@ -78,8 +78,8 @@ typedef struct _DMUS_PRIVATE_INSTRUMENT {
 
 typedef struct _DMUS_PRIVATE_BAND {
 	struct list entry; /* for listing elements */
-	DMUS_PRIVATE_BAND_ITEM_HEADER pBandHeader;
-	IDirectMusicBandImpl* ppBand;
+	DMUS_PRIVATE_BAND_ITEM_HEADER BandHeader;
+	IDirectMusicBandImpl* pBand;
 } DMUS_PRIVATE_BAND, *LPDMUS_PRIVATE_BAND;
 
 



More information about the wine-patches mailing list