dlls/winspool.drv/tests/info.c cleanups

Gerald Pfeifer gerald at pfeifer.com
Tue Jan 1 07:06:47 CST 2008


More of the same.

(cVersion is of type DWORD.)

Gerald

ChangeLog:
Adjust the typo of a loop variable in test_EnumForms().
Simplify a test in test_GetPrinterDriver().

Index: dlls/winspool.drv/tests/info.c
===================================================================
RCS file: /home/wine/wine/dlls/winspool.drv/tests/info.c,v
retrieving revision 1.42
diff -u -3 -p -r1.42 info.c
--- dlls/winspool.drv/tests/info.c	12 Dec 2007 15:30:46 -0000	1.42
+++ dlls/winspool.drv/tests/info.c	1 Jan 2008 12:24:28 -0000
@@ -768,7 +768,7 @@ static void test_EnumForms(LPSTR pName)
     DWORD   pcbNeeded;
     DWORD   pcReturned;
     DWORD   level;
-    INT     i;
+    UINT    i;
     const char *formtype;
     static const char * const formtypes[] = { "FORM_USER", "FORM_BUILTIN", "FORM_PRINTER", "FORM_flag_unknown" };
 #define FORMTYPE_MAX 2
@@ -2115,7 +2115,7 @@ static void test_GetPrinterDriver(void)
 
             /* MSDN is wrong: The Drivers on the win9x-CD's have cVersion=0x0400
                NT351: 1, NT4.0+w2k(Kernelmode): 2, w2k and above(Usermode): 3  */
-            ok((di_2->cVersion >= 0 && di_2->cVersion <= 3) ||
+            ok( (di_2->cVersion <= 3) ||
                 (di_2->cVersion == 0x0400), "di_2->cVersion = %d\n", di_2->cVersion);
             ok(di_2->pName != NULL, "not expected NULL ptr\n");
             ok(di_2->pEnvironment != NULL, "not expected NULL ptr\n");



More information about the wine-patches mailing list