wininet: InternetCrackUrlW: for URLs that have no urlpath, native clears lpszUrlPath
Dan Kegel
dank at kegel.com
Tue Jun 3 18:08:11 CDT 2008
Found by Valgrind.
Add one more URL to the InternetCrackUrlW test case,
fix the bug that confirms.
After the fix, tests pass on both XP and Wine.
I believe winex committed a similar fix in 2005,
http://lists.transgaming.org/pipermail/winex-devel/2005-March/000504.html
Here are the valgrind errors this fixes:
With WINEDEBUG=+wininet:
trace:wininet:InternetCrackUrlW L"http://www.winehq.org":
scheme(L"http") host(L"www.winehq.org") path(L"") extra(L"")
...
Conditional jump or move depends on uninitialised value(s)
by debugstr_w (debug.h:260)
by HttpOpenRequestW (http.c:914)
by INTERNET_InternetOpenUrlW (internet.c:2813)
by AsyncInternetOpenUrlProc (internet.c:2855)
by INTERNET_WorkerThreadFunc (internet.c:3044)
Uninitialised value was created by a stack allocation
at INTERNET_InternetOpenUrlW (internet.c:2743)
With or without WINEDEBUG=+wininet:
Conditional jump or move depends on uninitialised value(s)
at HTTP_HttpOpenRequestW (http.c:1931)
by HttpOpenRequestW (http.c:939)
by INTERNET_InternetOpenUrlW (internet.c:2813)
by AsyncInternetOpenUrlProc (internet.c:2855)
by INTERNET_WorkerThreadFunc (internet.c:3044)
Uninitialised value was created by a stack allocation
at INTERNET_InternetOpenUrlW (internet.c:2743)
(This was nearby
http://bugs.winehq.com/show_bug.cgi?id=1805
too bad it wasn't caught at the same time.)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: winineturl.patch
Type: text/x-patch
Size: 2219 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20080603/3afd45b3/attachment.bin
More information about the wine-patches
mailing list