msi: tests/source.c: initialize buffer lengths before calling MsiSourceListEnumMediaDisks

Dan Kegel dank at kegel.com
Thu Jun 5 18:58:54 CDT 2008


Those pesky in/out buffer length parameters...
Leaving the length uninitialized could result in
a short string returned, or possibly a buffer overflow,
but will definitely make Valgrind object.

Fixes lots of errors like:

Conditional jump or move depends on uninitialised value(s)
   at RtlAllocateHeap (heap.c:1194)
   by msi_alloc (msipriv.h:945)
   by MsiSourceListEnumMediaDisksA (source.c:171)
   by test_MsiSourceListEnumMediaDisks (source.c:2322)
   by func_source (source.c:3309)
 Uninitialised value was created by a stack allocation
   at test_MsiSourceListEnumMediaDisks (source.c:2291)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: msisource.patch
Type: text/x-diff
Size: 4354 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20080605/1b4e579c/attachment-0001.patch 


More information about the wine-patches mailing list