[1/2] tests: Add a win_skip() function to allow for missing Windows functionality that must be present in Wine.

Francois Gouget fgouget at free.fr
Tue Jun 10 11:29:46 CDT 2008


---

We routinely skip tests using skip() due to missing functionality. 
However these skips fall into two different categories that I feel 
should be handled separately.

The first situation is when the functionality is missing due to the 
hardware or the computer configuration. For instance if there is no 
printer or no sound card then there's no way we can test them so we have 
to skip some tests. For this case skip() is just fine.

The second situation is when the functionality is missing due to the 
Windows version being tested. For instance Win9x does not have 
RegQueryValueExW() so we skip the corresponding tests. However in this 
second case this also gives a free pass to Wine to not implement 
RegQueryValueExW() which should rather be considered a bug.
The same applies to other cases like the spooler service, it might be 
ok for it to be missing on Windows but maybe should be considered a bug 
in Wine.

So I propose to introduce win_skip() which would behave like skip() on 
Windows, but would behave like ok(0, ...) in Wine. Note that this would 
also make it possible to do stuff like 'todo_wine win_skip(...)' to 
handle cases where Wine is no yet up to the task.

 include/wine/test.h |   63 +++++++++++++++++++++++++++++++++++++-------------
 1 files changed, 46 insertions(+), 17 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: c69dd60106b1daa25c7c88156bd9a37461edc767.diff
Type: text/x-patch
Size: 6900 bytes
Desc: 
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20080610/6deffd67/attachment-0001.bin 


More information about the wine-patches mailing list