ntdll: don't copy unused bytes in create_user_params

Dan Kegel dank at kegel.com
Wed Jun 25 20:06:35 CDT 2008


This reduces the number of unused bytes sent to the server
when creating processes.
The ntdll, msvcrt, and advpack tests were helpful in vetting this patch.

Also fixes the Valgrind warning in advpack/tests/install.c:

Syscall param writev(vector[...]) points to uninitialised byte(s)
   at (within /lib/ld-2.7.so)
   by send_request (server.c:246)
   by wine_server_call (server.c:327)
   by wine_server_call_err (server.h:61)
   by create_process (process.c:1465)
   by CreateProcessW (process.c:1833)
   by launch_exe (install.c:899)
   by RunSetupCommandW (install.c:1004)
   by RunSetupCommandA (install.c:948)
   by test_RunSetupCommand (install.c:127)
 Uninitialised value was created by a client request
   at mark_block_uninitialized (heap.c:164)
   by RtlAllocateHeap (heap.c:1239)
   by RtlDosPathNameToNtPathName_U (path.c:394)
   by create_user_params (process.c:1318)
   by create_process (process.c:1401)
   by CreateProcessW (process.c:1833)
   by launch_exe (install.c:899)
   by RunSetupCommandW (install.c:1004)
   by RunSetupCommandA (install.c:948)
   by test_RunSetupCommand (install.c:127)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ntdll-env-create_user_params.patch
Type: text/x-diff
Size: 3856 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20080625/5c50cd6e/attachment.patch 


More information about the wine-patches mailing list