[PATCH] Implement IXMLDOMText appendData

Alistair Leslie-Hughes leslie_alistair at hotmail.com
Sat Mar 1 05:32:58 CST 2008


---
 dlls/msxml3/tests/domdoc.c |   15 +++++++++++++++
 dlls/msxml3/text.c         |   28 ++++++++++++++++++++++++++--
 2 files changed, 41 insertions(+), 2 deletions(-)

diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c
index bf4046b..0e50a8d 100644
--- a/dlls/msxml3/tests/domdoc.c
+++ b/dlls/msxml3/tests/domdoc.c
@@ -637,6 +637,21 @@ static void test_domdoc( void )
         ok(r == S_OK, "ret %08x\n", r );
         ok( !lstrcmpW( str, _bstr_("\\") ), "incorrect substringData string\n");
         SysFreeString(str);
+        
+        /* test appendData */
+        r = IXMLDOMText_appendData(nodetext, NULL);
+        ok(r == S_OK, "ret %08x\n", r );
+
+        r = IXMLDOMText_appendData(nodetext, _bstr_(""));
+        ok(r == S_OK, "ret %08x\n", r );
+
+        r = IXMLDOMText_appendData(nodetext, _bstr_("Append"));
+        ok(r == S_OK, "ret %08x\n", r );
+
+        r = IXMLDOMText_get_text(nodetext, &str);
+        ok(r == S_OK, "ret %08x\n", r );
+        ok( !lstrcmpW( str, _bstr_("This &is a ; test <>\\Append") ), "incorrect get_text string\n");
+        SysFreeString(str);
 
         IXMLDOMText_Release( nodetext );
     }
diff --git a/dlls/msxml3/text.c b/dlls/msxml3/text.c
index 4821e63..8a6a4ba 100644
--- a/dlls/msxml3/text.c
+++ b/dlls/msxml3/text.c
@@ -584,8 +584,32 @@ static HRESULT WINAPI domtext_appendData(
     IXMLDOMText *iface,
     BSTR p)
 {
-    FIXME("\n");
-    return E_NOTIMPL;
+    domtext *This = impl_from_IXMLDOMText( iface );
+    xmlnode *pDOMNode = impl_from_IXMLDOMNode( (IXMLDOMNode*)This->element );
+    xmlChar *pContent;
+    HRESULT hr = S_FALSE;
+    
+    TRACE("%p\n", iface);
+    
+    /* Nothing to do if NULL or an Empty string passed in. */
+    if(p == NULL || SysStringLen(p) == 0)
+        return S_OK;
+
+    pContent = xmlChar_from_wchar( (WCHAR*)p );
+    if(pContent)
+    {
+        if(xmlTextConcat(pDOMNode->node, pContent, SysStringLen(p) ) == 0)
+            hr = S_OK;
+        else
+        {
+            hr = E_FAIL;
+            xmlFree(pContent);
+        }
+    }
+    else
+        hr = E_FAIL;
+    
+    return hr;
 }
 
 static HRESULT WINAPI domtext_insertData(
-- 
1.5.4.1


--------------040609060402070605080107--




More information about the wine-patches mailing list