[PATCH 1/3] shell32: add xdg-user-dirs lookup code

Lei Zhang thestig at google.com
Tue Mar 4 18:25:20 CST 2008


On Wed, Nov 28, 2007 at 2:31 PM, Alexandre Julliard <julliard at winehq.org> wrote:
> "Lei Zhang" <thestig at google.com> writes:
>
>  > I was not sure if was alright to mix code with different licenses in
>  > the same file. I looked around and found that
>  > include/wine/wined3d_gl.h has both LGPL Wine code as well as MIT
>  > licensed code from the Mesa project. Based on that, I guess it's ok to
>  > do, so I will send out another patch.
>
>  It's OK to do, but I don't think you want to copy the code as is, you
>  should write your own version that parses the file only once and handles
>  variables as they are found. Also these variables should take priority
>  over the default heuristics, and you most likely want to handle the
>  desktop dir the same way.

Ok, here's the revised version that only parses the file once. Still
contains a lot of code from xdg-user-dirs.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-shell32-add-xdg-user-dirs-lookup-code.patch
Type: text/x-patch
Size: 9543 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20080304/0ffac19c/attachment-0001.bin 


More information about the wine-patches mailing list