RESEND Prototype patch that solves bug 11897

[Artur Szymiec]

Vitaliy Margolen pisze:
> Artur Szymiec wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Stefan Dösinger pisze:
>>> Am Donnerstag, 13. März 2008 10:19:36 schrieb Artur Szymiec:
>>>> This is a corrected patch. The uuid is common to dx8 and dx9
>>>> since the UUID is generated inside wined3d.
>>> Yes, that looks reasonable. Only two small issues:
>>>
>>>> +/* Fixes BUG 11897 */
>>> That's not really needed, specifying a GUID is correct even if it
>>> wouldn't fix a bug report.
>>>
>>> Also, please attach the patch as an extra file to the mail, if you
>>> inline it like you did in your last mails it most likely suffers
>>> from line wrapping and can't be applied
>> Thank you very much for help Stefan !
>>
> Few more problems with your patch:
>> +const GUID IID_D3DDEVICE_D3DUID = {
>> +  0xaeb2cdd4,
>> +  0x6e41,
> 1. Use 4 spaces indentation as the rest of the file not 2.
>
>> +   
>> memcpy(pIdentifier->DeviceIdentifier,&IID_D3DDEVICE_D3DUID,sizeof(GUID));
>>
> 2. Don't use memcpy. They are both structs and you you can assign
> sctruct to struct in c:
>     *pIdentifier->DeviceIdentifier = IID_D3DDEVICE_D3DUID;
>
> Vitaliy.
>
With corrections as suggested.

Regards

Artur

-- 
--------------------------------------------------------------------------
Registered User No 397465
Linux Debian 2.6.24.2 AMD Athlon(tm) 64 X2 Dual Core 5000+
Conquer your Desktop! http://www.kde.org/trykde/
Reclaim Your Inbox!   http://www.mozilla.org/products/thunderbird/
--------------------------------------------------------------------------

-------------- next part --------------
A non-text attachment was scrubbed...
Name: UUID.patch
Type: text/x-diff
Size: 967 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20080313/7733e9ac/attachment.patch