advapi32: Assign to struct instead of using memcpy

Andrew Talbot andrew.talbot at talbotville.com
Thu Mar 27 17:15:19 CDT 2008


I'm tackling some less straightforward cases now, and am grateful for watchful
eyes and any informative feedback.

Thanks,

-- Andy.
---
Changelog:
    advapi32: Assign to struct instead of using memcpy.

diff --git a/dlls/advapi32/security.c b/dlls/advapi32/security.c
index 333ad86..fa18ed9 100644
--- a/dlls/advapi32/security.c
+++ b/dlls/advapi32/security.c
@@ -407,7 +407,7 @@ static void GetWorldAccessACL(PACL pACL)
     pACE->Header.AceFlags = CONTAINER_INHERIT_ACE;
     pACE->Header.AceSize = sizeof(ACCESS_ALLOWED_ACE) + sizeof(sidWorld) - sizeof(DWORD);
     pACE->Mask = 0xf3ffffff; /* Everything except reserved bits */
-    memcpy(&pACE->SidStart, &sidWorld, sizeof(sidWorld));
+    *(SID *)&pACE->SidStart = sidWorld;
 }
 
 /************************************************************



More information about the wine-patches mailing list