[PATCH] remove superflous empty region allocation

Marcus Meissner marcus at jet.franken.de
Wed May 14 07:44:43 CDT 2008


Coverity spotted this as resource leak and I agree.

tmp is assigned later on unconditionally and only
used after this second assignment.

Ciao, Marcus
---
 server/window.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/server/window.c b/server/window.c
index 9530c61..a000cfc 100644
--- a/server/window.c
+++ b/server/window.c
@@ -1105,7 +1105,7 @@ static int add_update_region( struct window *win, struct region *region )
 static void crop_children_update_region( struct window *win, rectangle_t *rect )
 {
     struct window *child;
-    struct region *tmp = create_empty_region();
+    struct region *tmp;
     rectangle_t child_rect;
 
     LIST_FOR_EACH_ENTRY( child, &win->children, struct window, entry )
-- 
1.5.2.4



More information about the wine-patches mailing list