[PATCH 3/6] server: refactor server side implementation of GetFileSecurity()

Paul Bryan Roberts pbronline-wine at yahoo.co.uk
Tue Nov 4 02:03:49 CST 2008


This patch is one a series intended to fix Bug 14434 (WordPerfect Office 
2002:  Unable to Install).

The problem here is that the installer calls GetFileSecurity() on 
directories, not files while the Wine server only has support for this 
API call for files, not directories.

The solution seems simple - implement support for directories by cloning 
the support for files.  Provided, of course, that this is backed up by 
cloning the conformance tests.

The problem here is that while file_set_sd() delegates to sd_to_mode() 
the code that needs to be common between the file and directory cases, 
file_get_sd() does not.

This patch factors out into mode_to_sd() the code that needs to be 
common between the file and directory cases and makes it and 
sd_to_mode() callable from outside the compilation unit.

This patch is conformance test neutral.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0003-server-refactor-server-side-implementation-of-GetFile.txt
Url: http://www.winehq.org/pipermail/wine-patches/attachments/20081104/6af30607/attachment.txt 


More information about the wine-patches mailing list