advapi32/tests: [Patch 2/2] Fix broken GetLastError tests

Detlef Riekenberg wine.dev at web.de
Sun Nov 9 15:08:32 CST 2008


The recently added test are still not correct.
- The result of GetLastError is only valid, when the tested Function
failed.
  Exceptions exists, but they are really rare and either documented or a
  (broken) application depends on this implementation dependant
behavior.

- When checking the result of GetLastError, the value of SetLastError
  must not be NO_ERROR, but an unusual value instead. We use 0xdeadbeef.

Replacing all "SetLastError(NO_ERROR)" with "SetLastError(0xdeadbeef)"
let the (now removed) tests fail on w2k


-- 
 
By by ... Detlef

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-advapi32-tests-Fix-broken-GetLastError-tests.txt
Type: application/mbox
Size: 0 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20081109/084d4c2f/attachment.bin 


More information about the wine-patches mailing list