[PATCH 2/2] widl: Fix optimisation for writing out ref pointers to simple structs and base types.

Rob Shearman robertshearman at gmail.com
Sun Nov 30 10:25:06 CST 2008


The optimisation in write_remoting_arg for sizing, marshalling,
unmarshalling and freeing ref pointers to base types directly was
broken in d458a599eb8efa192004e0a0bea745be0d1cc0be and caused
unnecessary calls to pointer marshalling functions.

The same was true for a similar optimisation for simple structures
where their size can be pre-calculated, freeing omitted and the
NdrSimpleStructMarshall/Unmarshall functions called directly instead
of calling NdrPointerMarshall/Unmarshall first.

Fix this by looking at the type of the referrent instead of the type
of the pointer, making sure to not classify user types as simple
structures.

Additionally remove some dead code that would never be executed
because the code is in an RPC_FC_RP case, inside a !is_ptr if block
(and RPC_FC_RP is a pointer type).
---
 tools/widl/typegen.c |   36 +++++++++---------------------------
 1 files changed, 9 insertions(+), 27 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ce16972b223c831c3eefb7f05e437b0a0c54ae1b.diff
Type: text/x-patch
Size: 3317 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20081130/d8a1ed62/attachment.bin 


More information about the wine-patches mailing list