[1/5] msxml3/tests: Valgrind fix. (try 2)

Michael Karcher wine at mkarcher.dialup.fu-berlin.de
Tue Oct 7 04:54:45 CDT 2008


sName is an uninitialized pointer if GetMemberName faild.

try 2: used SUCCEEDED instead of !FAILED (James Hawkins)
---
 dlls/msxml3/tests/domdoc.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c
index 1ad168b..57d8689 100644
--- a/dlls/msxml3/tests/domdoc.c
+++ b/dlls/msxml3/tests/domdoc.c
@@ -1565,7 +1565,8 @@ static void test_getElementsByTagName(void)
 
         r = IDispatchEx_GetMemberName(dispex, dispid, &sName);
         ok(r == E_NOTIMPL, "expected E_NOTIMPL got %08x\n", r);
-        SysFreeString(sName);
+        if( SUCCEEDED(r) )
+            SysFreeString(sName);
 
         r = IDispatchEx_GetNextDispID(dispex, fdexEnumDefault, DISPID_XMLDOM_NODELIST_RESET, &dispid);
         ok(r == E_NOTIMPL, "expected E_NOTIMPL got %08x\n", r);
-- 
1.5.6.5




More information about the wine-patches mailing list