[PATCH] advapi: removed redundant NULL check

Marcus Meissner marcus at jet.franken.de
Thu Oct 30 17:49:24 CDT 2008


Hi,

Coverity CID 813, domainName check for NULl is superflous,
since we check strlenW() before, and we assign it to a knonw
NULL value.

Ciao, Marcus
---
 dlls/advapi32/security.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/advapi32/security.c b/dlls/advapi32/security.c
index 2093f7e..f57136d 100644
--- a/dlls/advapi32/security.c
+++ b/dlls/advapi32/security.c
@@ -2661,7 +2661,7 @@ BOOL WINAPI LookupAccountNameW( LPCWSTR lpSystemName, LPCWSTR lpAccountName, PSI
         nameLen += 1;
         ret = FALSE;
     }
-    else if (ReferencedDomainName && domainName)
+    else if (ReferencedDomainName)
     {
         strcpyW(ReferencedDomainName, domainName);
     }
-- 
1.5.6



More information about the wine-patches mailing list