[1/6] comctl32/listview: Fix some test failures on comctl32 4.7x

Nikolay Sivov bunglehead at gmail.com
Sun Aug 2 17:54:34 CDT 2009


I have to mask todo_wine here, cause these optionals make it pass.
todo is left as a comment.

Changelog:
    - Fix some test failures on comctl32 4.7x


>From 9a59eec64229bf77db13857b7e27a06236265491 Mon Sep 17 00:00:00 2001
From: Nikolay Sivov <bunglehead at gmail.com>
Date: Mon, 3 Aug 2009 01:44:31 +0400
Subject: Fix some test failures on comctl32 4.7x

---
 dlls/comctl32/tests/listview.c |   12 ++++++++----
 1 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/dlls/comctl32/tests/listview.c b/dlls/comctl32/tests/listview.c
index 888b323..4ac14d5 100644
--- a/dlls/comctl32/tests/listview.c
+++ b/dlls/comctl32/tests/listview.c
@@ -267,14 +267,18 @@ static const struct message getitemposition_seq2[] = {
 
 static const struct message editbox_create_pos[] = {
     /* sequence sent after LVN_BEGINLABELEDIT */
+    /* next two are 4.7x specific */
     { WM_WINDOWPOSCHANGING, sent },
+    { WM_WINDOWPOSCHANGED, sent|optional },
+
+    { WM_WINDOWPOSCHANGING, sent|optional },
     { WM_NCCALCSIZE, sent },
     { WM_WINDOWPOSCHANGED, sent },
     { WM_MOVE, sent|defwinproc },
     { WM_SIZE, sent|defwinproc },
-    /* the rest is todo */
-    { WM_WINDOWPOSCHANGING, sent },
-    { WM_WINDOWPOSCHANGED, sent },
+    /* the rest is todo, skipped in 4.7x */
+    { WM_WINDOWPOSCHANGING, sent|optional },
+    { WM_WINDOWPOSCHANGED, sent|optional },
     { 0 }
 };
 
@@ -3440,7 +3444,7 @@ static void test_editbox(void)
     ok(IsWindow(hwndedit), "Expected Edit window to be created\n");
     /* testing only sizing messages */
     ok_sequence(sequences, EDITBOX_SEQ_INDEX, editbox_create_pos,
-                "edit box create - sizing", TRUE);
+                "edit box create - sizing", FALSE);
 
     DestroyWindow(hwnd);
 }
-- 
1.5.6.5







More information about the wine-patches mailing list